Summary: | Multi transport types: the print notices should be processed in first | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, m.de.rooy, olli-antti.kivilahti |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 10832 | ||
Bug Blocks: | |||
Attachments: |
Bug 11696: The print notices should be processed in first
Bug 11696: The print notices should be processed in first Bug 11696: The print notices should be processed in first |
Description
Jonathan Druart
2014-02-06 10:53:05 UTC
Created attachment 25069 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Created attachment 25070 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Pretty slick solution! gg Created attachment 27530 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Olli-Antti Kivilahti from comment #3) > Pretty slick solution! This solution works. But I think that in terms of QA and maintenance it is not the most elegant one. Pushed to master. Thanks, Jonathan! |