Bug 11696 - Multi transport types: the print notices should be processed in first
Summary: Multi transport types: the print notices should be processed in first
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 10832
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-06 10:53 UTC by Jonathan Druart
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11696: The print notices should be processed in first (2.38 KB, patch)
2014-02-06 10:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11696: The print notices should be processed in first (2.44 KB, patch)
2014-02-06 11:56 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11696: The print notices should be processed in first (2.54 KB, patch)
2014-04-24 12:03 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-02-06 10:53:05 UTC
On bug 10832 comment 12, a specific cause an issue.
If email, print and sms are checked (for overdues for instance), and no email exists for the user, the email template will be used to sent the print notice.

The print notices should be processed in first to avoid this problem.
Comment 1 Jonathan Druart 2014-02-06 10:55:42 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2014-02-06 11:56:27 UTC Comment hidden (obsolete)
Comment 3 Olli-Antti Kivilahti 2014-02-06 11:59:27 UTC
Pretty slick solution!

gg
Comment 4 Marcel de Rooy 2014-04-24 12:03:29 UTC
Created attachment 27530 [details] [review]
Bug 11696: The print notices should be processed in first

This reorder avoids to sent a print notice with an email or sms template
is no email or sms is defined.

Test plan:
Check print, sms and email for an overdue rule
Don't define an email address and generate an overdue for a user
Define 3 templates for the notice used
Launch the cronjob script and verify the print notice is generated using
the print template.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2014-04-24 12:05:34 UTC
(In reply to Olli-Antti Kivilahti from comment #3)
> Pretty slick solution!

This solution works. But I think that in terms of QA and maintenance it is not the most elegant one.
Comment 6 Galen Charlton 2014-05-02 21:22:00 UTC
Pushed to master.  Thanks, Jonathan!