Description
Katrin Fischer
2014-02-14 14:03:20 UTC
Problem is caused by mismatching XSLT in: + MARC21 - koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACMARCdetail.xsl - koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl - koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl - koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl - koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl - koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl + NORMARC: - koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl - koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACResults.xsl - koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl - koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl - koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl - koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl I'm submitting patches to correct these mis-matches in favour of the display in Detail.xsl (a h b). Best wishes, Alex Created attachment 26305 [details] [review] Bug 11762 - bootstrap: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21 in BOOTSTRAP: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view on the OPAC (bootstrap). - Apply the patch. - Re-check detail and results view: all should now look the same on the OPAC (bootstrap). Created attachment 26306 [details] [review] Bug 11762 - intranet & prog: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view in OPAC (non-bootstrap) and intranet (you should see a discrepancies). - Apply the patch. - Re-check detail and results view: all should now look the same in both OPAC (non-bootstrap) and intranet. Created attachment 26315 [details] [review] Bug 11762 - intranet & prog: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view in OPAC (non-bootstrap) and intranet (you should see a discrepancies). - Apply the patch. - Re-check detail and results view: all should now look the same in both OPAC (non-bootstrap) and intranet. Created attachment 26316 [details] [review] Bug 11762 - bootstrap: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21 in BOOTSTRAP: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view on the OPAC (bootstrap). - Apply the patch. - Re-check detail and results view: all should now look the same on the OPAC (bootstrap). Created attachment 26317 [details] [review] Bug 11762 - intranet & prog: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view in OPAC (non-bootstrap) and intranet (you should see a discrepancies). - Apply the patch. - Re-check detail and results view: all should now look the same in both OPAC (non-bootstrap) and intranet. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Created attachment 26318 [details] [review] Bug 11762 - bootstrap: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21 in BOOTSTRAP: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view on the OPAC (bootstrap). - Apply the patch. - Re-check detail and results view: all should now look the same on the OPAC (bootstrap). Signed-off-by: Jesse Weaver <pianohacker@gmail.com> You forgot to mark as signed off, Jesse. :) Created attachment 26340 [details] [review] [PASSED QA] Bug 11762 - intranet & prog: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view in OPAC (non-bootstrap) and intranet (you should see a discrepancies). - Apply the patch. - Re-check detail and results view: all should now look the same in both OPAC (non-bootstrap) and intranet. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described. Checked with Magnus Enger about the changes for the NORMARC stylesheets and the changes are ok. Created attachment 26341 [details] [review] [PASSED QA] Bug 11762 - bootstrap: Re-order 245 $a $b $h in results. In the results view for OPAC and Intranet search results, titles are currently displayed in 245 $a $b $h order. In detailed view the titles are displayed in the better 245 $a $h $b order. This patch corrects the behaviour for NORMARCS and MARC21 in BOOTSTRAP: all now display 245 $a $h $b. To test: - Find records containing 245 $a $b and $h fields. - Compare the way they look in detail and results view on the OPAC (bootstrap). - Apply the patch. - Re-check detail and results view: all should now look the same on the OPAC (bootstrap). Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. This appears to the first patch of yours accepted into Koha master. Congratulations, Alex! *** Bug 6502 has been marked as a duplicate of this bug. *** Pushed to 3.14.x, will be in 3.14.08 Pushed to 3.12.x, will be in 3.12.13 *** Bug 12766 has been marked as a duplicate of this bug. *** |