Bug 11766

Summary: Use validation plugin when creating new authority type
Product: Koha Reporter: Owen Leonard <oleonard>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/admin/authtypes.pl?op=add_form
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11764, 11765    
Bug Blocks: 11767    
Attachments: Bug 11766 - Use validation plugin when creating new authority type
Bug 11766 - Use validation plugin when creating new authority type
r Attachment to Bug 11766 - Use validation plugin when creating new authority type

Description Owen Leonard 2014-02-14 18:08:45 UTC
The new authority type entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-14 18:57:32 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-19 05:11:05 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-19 08:49:09 UTC
Created attachment 25424 [details] [review]
r Attachment to Bug 11766 - Use validation plugin when creating new authority type

Bug 11766 - Use validation plugin when creating new authority type

The new authority type entry form uses custom form validation
JavaScript. This patch removes it in favor of using HTML5 validation
attributes and Koha's built-in validation plugin.

To test, go to Administration -> Authority types and click "New
authority type." Try submitting the form without entering any data. You
should see a warning about required fields. Upon entering text in those
fields the warning should disappear.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-19 17:15:35 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:48:33 UTC
Pushed to 3.14.x, will be in 3.14.07

Nice work, HTML5 is really usefull.