Bug 11766 - Use validation plugin when creating new authority type
Summary: Use validation plugin when creating new authority type
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL: /cgi-bin/koha/admin/authtypes.pl?op=a...
Keywords:
Depends on: 11764 11765
Blocks: 11767
  Show dependency treegraph
 
Reported: 2014-02-14 18:08 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11766 - Use validation plugin when creating new authority type (4.38 KB, patch)
2014-02-14 18:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11766 - Use validation plugin when creating new authority type (4.39 KB, patch)
2014-02-19 05:11 UTC, Chris Cormack
Details | Diff | Splinter Review
r Attachment to Bug 11766 - Use validation plugin when creating new authority type (4.45 KB, patch)
2014-02-19 08:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-14 18:08:45 UTC
The new authority type entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-14 18:57:32 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-19 05:11:05 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-19 08:49:09 UTC
Created attachment 25424 [details] [review]
r Attachment to Bug 11766 - Use validation plugin when creating new authority type

Bug 11766 - Use validation plugin when creating new authority type

The new authority type entry form uses custom form validation
JavaScript. This patch removes it in favor of using HTML5 validation
attributes and Koha's built-in validation plugin.

To test, go to Administration -> Authority types and click "New
authority type." Try submitting the form without entering any data. You
should see a warning about required fields. Upon entering text in those
fields the warning should disappear.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-19 17:15:35 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:48:33 UTC
Pushed to 3.14.x, will be in 3.14.07

Nice work, HTML5 is really usefull.