Summary: | Use validation plugin when creating new course | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Course reserves | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/course_reserves/course.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11788 - Use validation plugin when creating new course
Bug 11788 - Use validation plugin when creating new course Bug 11788 - Use validation plugin when creating new course |
Description
Owen Leonard
2014-02-18 20:26:15 UTC
Created attachment 25395 [details] [review] Bug 11788 - Use validation plugin when creating new course The page for adding a new course includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Course reserves -> New course. Try submitting the form without entering a department, course number, and/or course name. This should trigger validation warnings. Submission of the form with valid data should work correctly. Editing an existing course should also work correctly. Created attachment 25407 [details] [review] Bug 11788 - Use validation plugin when creating new course The page for adding a new course includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Course reserves -> New course. Try submitting the form without entering a department, course number, and/or course name. This should trigger validation warnings. Submission of the form with valid data should work correctly. Editing an existing course should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25482 [details] [review] Bug 11788 - Use validation plugin when creating new course The page for adding a new course includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Course reserves -> New course. Try submitting the form without entering a department, course number, and/or course name. This should trigger validation warnings. Submission of the form with valid data should work correctly. Editing an existing course should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |