Bug 11788 - Use validation plugin when creating new course
Summary: Use validation plugin when creating new course
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/course_reserves/course.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-18 20:26 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11788 - Use validation plugin when creating new course (5.08 KB, patch)
2014-02-18 20:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11788 - Use validation plugin when creating new course (5.10 KB, patch)
2014-02-19 00:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11788 - Use validation plugin when creating new course (5.16 KB, patch)
2014-02-20 10:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-18 20:26:15 UTC
The new course entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-18 20:29:36 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-19 00:28:23 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-20 10:03:21 UTC
Created attachment 25482 [details] [review]
Bug 11788 - Use validation plugin when creating new course

The page for adding a new course includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.

To test, apply the patch and go to Course reserves -> New course. Try
submitting the form without entering a department, course number,
and/or course name. This should trigger validation warnings.

Submission of the form with valid data should work correctly. Editing an
existing course should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-20 17:07:52 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-21 08:03:00 UTC
Pushed to 3.14.x, will be in 3.14.07