Summary: | opacSerialDefaultTab being ignored | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | abl, fridolin.somers, gmcharlt, jesse, marjorie.barry-vila, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11794 - opacSerialDefaultTab being ignored
Bug 11794 - opacSerialDefaultTab being ignored [SIGNED-OFF] Bug 11794 - opacSerialDefaultTab being ignored Bug 11794 - opacSerialDefaultTab being ignored [PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored |
Description
Nicole C. Engard
2014-02-19 17:39:28 UTC
Created attachment 25515 [details] [review] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Why did you remove it in the auth ones? Created attachment 25843 [details] [review] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Created attachment 25976 [details] [review] [SIGNED-OFF] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 25977 [details] [review] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Created attachment 25982 [details] [review] [PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored The opacSerialDefaultTab system preference should control whether to show the holdings or subscriptions tab by default on the detail page for a serial. This behavior was broken when we last updated jQueryUI because of a change in the jQueryUI active tab class name. This patch corrects the class on the detail page and removes the old class from the authorities detail page (where it was unnecessary anyway). To test, view a serial record in the OPAC under various settings of the opacSerialDefaultTab preference. The default tab should correctly follow the preference. Test in prog and Bootstrap themes. Edit: Rebased on current master. Note that the change to opac-auth-detail.tt is because the page never has more than one tab, hence doesn't need the "active" designation. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested in prog and bootstrap. All tests and QA script pass. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 |