Summary: | Results with 6 facets have missing facet | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Searching | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11796 - Results with 6 facets have missing facet
Bug 11796 - Results with 6 facets have missing facet Bug 11796 - Results with 6 facets have missing facet |
Description
Kyle M Hall (khall)
2014-02-19 20:26:12 UTC
Created attachment 25466 [details] [review] Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Created attachment 25471 [details] [review] Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 25484 [details] [review] Bug 11796 - Results with 6 facets have missing facet If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch should provide a regression test but I really don't know how to write it. Pushed to master. Thanks, Kyle! Pushed to 3.14.x, will be in 3.14.07 (really tricky bug, but a classic boundaries problem in mathematics) Pushed to 3.12.x will be in 3.12.13 |