Summary: | Staff client next/previous browse JavaScript interferes with other JS functions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gaetan.boisson, jonathan.druart, library |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12821 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 10404 | ||
Bug Blocks: |
Description
Owen Leonard
2014-02-21 19:22:53 UTC
I suggest to remove the browser feature from cataloging module. It works perfectly for catalogue module, but for cataloging module, I think it can cause too much bugs (In reply to Fridolin SOMERS from comment #1) > I suggest to remove the browser feature from cataloging module. What do you mean by the cataloging module? Do you mean the staff client? Can you please point out the bugs you know of? (In reply to Owen Leonard from comment #2) > (In reply to Fridolin SOMERS from comment #1) > > I suggest to remove the browser feature from cataloging module. > > What do you mean by the cataloging module? Do you mean the staff client? Can > you please point out the bugs you know of? No I mean the pages additem and addbiblio, they have been modified by (In reply to Owen Leonard from comment #2) > (In reply to Fridolin SOMERS from comment #1) > > I suggest to remove the browser feature from cataloging module. > > What do you mean by the cataloging module? Do you mean the staff client? Can > you please point out the bugs you know of? No I mean the pages additem and addbiblio, they have been modified by Bug 10404. And it is for them that this code exists : $('a[href*="biblionumber="]').click(function (ev) If only catalogue module is used, we could change this code to : $('a[href*="detail.pl?biblionumber="]').click(function (ev) By the way, addbiblio has been changed but the browser does not appear in page. According to Jared the addbiblio and additem pages are modified for two cases: - Search for a title -> View a title -> Edit that title -> Save the record -> Redirected to title view: Next/previous links are still present - Search for a title -> View a title -> Edit items -> Next/previous links are visible on the edit item screen. The only bug that I see here is that the "return to results" link from the item edit screen isn't working for me. Fridolin are there other bugs you see? You must be seeing serious problems if you're recommending that the feature be removed. (In reply to Owen Leonard from comment #5) > The only bug that I see here is that the "return to results" link from the > item edit screen isn't working for me. The most important problem is the deletion of a record you reported in first comment. It's a big problem no ? When one clicks on "delete record", if the record has items attached, the javascript alert is displayed very briefly, then skipped, and Koha proceeds to the deletebiblio page. The record will not be deleted but we end up with a disgraceful full page message: ERROR when DELETING BIBLIO 433 : This Biblio has items attached, please delete them first before deleting this biblio While there doesn't seem to be a risk of accidentally deleting data, it would be good to fix this behaviour. I spoke a little too fast here : this seems to be fixed in master. But i also can't see the link back to results right now, so this might be linked. Is this problem still exist on master? It seems that bug 11821 corrected it. *** Bug 12378 has been marked as a duplicate of this bug. *** I agree with Jonathan -- Bug 11821 seems to have fixed this bug. |