Bug 11821 - Staff client catalog: delete menu items greyed out without explanation
Summary: Staff client catalog: delete menu items greyed out without explanation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 11819 11829
Blocks: 25251
  Show dependency treegraph
 
Reported: 2014-02-21 20:20 UTC by Owen Leonard
Modified: 2020-04-29 10:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11821 - Staff client catalog: delete menu items greyed out without explanation (5.80 KB, patch)
2014-02-24 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11821 - Staff client catalog: delete menu items greyed out without explanation (5.81 KB, patch)
2014-02-28 16:34 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11821 - Staff client catalog: delete menu items greyed out without explanation (5.92 KB, patch)
2014-03-12 11:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-21 20:20:04 UTC
If you view a title in the staff client which has items attached the edit menu item "Delete record" will be greyed out. Like the fix in Bug 2310 a tooltip should be added explaining why.

Similarly, menu items which relate to operations on items should be disabled (with explanation) if the record has no items.
Comment 1 Owen Leonard 2014-02-24 17:19:33 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-02-28 16:34:15 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-12 11:47:24 UTC
Created attachment 26164 [details] [review]
[PASSED QA] Bug 11821 - Staff client catalog: delete menu items greyed out without explanation

Biblio edit menu items which are disabled should trigger a tooltip
on hover and an alert on click with explanations. This patch implements
this for the relevent menu items.

To test, apply the patch for Bug 11829 if necessary. Find a record which
has no items attached. Test the following views:

- Normal
- MARC
- Labeled MARC
- ISBD
- Items

Test these Edit menu items:

- Edit items in a batch
- Delete items in a batch
- Delete all items

Hovering over these menu items should trigger an explanatory tooltip.
Clicking the menu items should trigger a similar alert.

Next, locate a title with items attached. On the same pages above, test
the Edit -> Delete record menu item. Hovering should trigger an
explanatory tooltip. Clicking it should trigger a similar alert.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works nicely.
Comment 4 Galen Charlton 2014-03-12 14:58:34 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-03 11:02:52 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 6 Kyle M Hall 2014-06-06 13:58:03 UTC
Pushed to 3.12.x will be in 3.12.13