Summary: | Don't show catalog edit menu if user has no edit permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 11821 | ||
Attachments: |
Bug 11819 - Don't show catalog edit menu if user has no edit permissions
[Signed-off]Bug 11819 - Don't show catalog edit menu if user has no edit permissions [PASSED QA] Bug 11819 - Don't show catalog edit menu if user has no edit permissions |
Description
Owen Leonard
2014-02-21 19:49:26 UTC
Created attachment 25550 [details] [review] Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Created attachment 25557 [details] [review] [Signed-off]Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Followed test plan, patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 25564 [details] [review] [PASSED QA] Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Followed test plan, patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. Template only change. Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07 Pushed to 3.12.x will be in 3.12.13 |