Summary: | Random password suggestion does not work twice | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Staff interface | Assignee: | Juhani Seppälä <jseppal> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | abl, gmcharlt, isaacbrodsky, jseppal, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11888: Random password suggestion does not work twice
Bug 11888: Random password suggestion does not work twice [Signed-off] Bug 11888: Random password suggestion does not work twice [PASSED QA] Bug 11888: Random password suggestion does not work twice |
Description
Marc Véron
2014-03-04 13:46:04 UTC
Clicking on "Click to fill with a randomly generated suggestion. Passwords will be displayed as text." a second time without clearing the new password does not work. Koha 3.14.04 on Debian. Created attachment 29781 [details] [review] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. This looks good except for a couple of really minor issues: The path to the "loading" image is hard-coded to the prog theme, and the image lacks an alt attribute. <img src="/intranet-tmpl/prog/img/loading.gif" /> ...should be: <img src="[% interface %]/[% theme %]/img/loading.gif" alt="" /> I see one other thing: <strong>Processing...<strong> The second <strong> should be </strong> Created attachment 30011 [details] [review] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Newest patch corrects the broken page elements. Created attachment 30146 [details] [review] [Signed-off] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Hi Juhani, thx for the patch. :) Just a note: Sometimes the length of the generated password is minPasswordLength+1. It never seems to be shorter or longer and it happens before and after the patch. Created attachment 30163 [details] [review] [PASSED QA] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as desribed. (In reply to Katrin Fischer from comment #8) > Hi Juhani, thx for the patch. :) > > Just a note: Sometimes the length of the generated password is > minPasswordLength+1. It never seems to be shorter or longer and it happens > before and after the patch. Hi, I noticed this behaviour as well while looking at creating this small fix. As mentioned here: Bug 12617 (shameless ad), we've had some discussion at our library about being able to have more configuration choices with regards to patron passwords and I've done some preliminary work on changing the current custom password generation to use a cpan library for easy configurability and so forth. We also have a damning limitation with some of the appliances used by customers where the devices only have numeric keys for password input... Things I'm looking at: - Making generated password complexity configurable - Allow admins to enforce a separate password policy for regular patrons and employees (for example) I would be interested in hearing any thoughts related to this and whether any of this would be useful in the community (we have some specific requirements here after all). Patch pushed to master. Thanks Juhani! |