| Summary: | add table sorters to label batches | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
card batch
Bug 11946 - add table sorters to label and patron card batches Bug 11946 - add table sorters to label and patron card batches [SIGNED-OFF] Bug 11946 - add table sorters to label and patron card batches [PASSED QA] Bug 11946 - add table sorters to label and patron card batches |
||
Created attachment 26532 [details] [review] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Created attachment 26564 [details] [review] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Created attachment 26565 [details] [review] [SIGNED-OFF] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. More accurately, I asked to get the sorter added to patron cards and when I reported the issue here I said patron cards and labels in the title. So if there can be a follow up to add this to the patron cards that would be awesome! Nicole Created attachment 26701 [details] [review] [PASSED QA] Bug 11946 - add table sorters to label and patron card batches When viewing batches of titles in the label creator module the table is not sortable. This patch adds table sorting. The patch also makes some corrections of invalid markup and moves informational/error messages to the top of the page rather than in a sidebar. This change lets the table and sorting controls expand into a wider space. To test, go to Tools -> Labels -> Manage label batches. View an existing batch or create a new batch and populate it with items. Table sorting controls should work correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Solves 1/2 of this bug which is to add the sorters to labels, the original request was to add this to patron cards as well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Template could be improved forther by showing the itemtype description instead of the code in the table. Pushed to master. Since the patch covered only half of the request, I've opened a new bug, bug 12018, for the patron card portion. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.08 |
Created attachment 26373 [details] card batch When viewing a big batch of cards it's often handy to be able to sort. On this page: cgi-bin/koha/patroncards/edit-batch.pl it would be nice to see the new table sorter/search.