Bug 12018 - add table sorting to patron card batches
Summary: add table sorting to patron card batches
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Nighswonger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-31 14:24 UTC by Galen Charlton
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12018 - add table sorting to patron card batches (8.49 KB, patch)
2014-04-02 14:47 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12018 - add table sorting to patron card batches (8.53 KB, patch)
2014-04-02 20:11 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 12018 - add table sorting to patron card batches (8.58 KB, patch)
2014-04-03 13:00 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2014-03-31 14:24:57 UTC
Table sorting should be added to the list of records in the patron card batch.  Bug 11946 should be viewed for more details and a screenshot; I opened this bug since the patch that was pushed for 11946 only covered the item label batches part of the original bug.
Comment 1 Owen Leonard 2014-04-02 14:47:07 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2014-04-02 20:11:09 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-04-03 13:00:14 UTC
Created attachment 26791 [details] [review]
Bug 12018 - add table sorting to patron card batches

When viewing batches of patrons in the patron card creator module the
table is not sortable. This patch adds table sorting.

The patch also makes some corrections of invalid markup and moves
informational/error messages to the top of the page rather than in a
sidebar. This change lets the table and sorting controls expand into a
wider space.

This patch also corrects a translation issue with table headers
identical to that addressed by Bug 11505.

To test, go to Tools -> Patron card creator -> Manage batches.
View an existing batch or create a new batch and populate it with
patrons. Table sorting controls should work correctly. Batch management
operations should work correctly.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-04-03 15:26:17 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-19 14:25:32 UTC
Pushed to 3.14.x, will be in 3.14.08