Bug 12011

Summary: ReservesNeedReturns breaks 'Hold Filled' notice functionality
Product: Koha Reporter: David Cook <dcook>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description David Cook 2014-03-28 06:23:23 UTC
If you have the system preference "ReservesNeedReturns" turned on, notices for "Holds Filled" won't be generated because the logic thinks that it has already sent one.

As far as I can tell, "notificationdate" doesn't even appear to be used. That seems like it would be an excellent place to record the date that a notice was sent out...
Comment 1 David Cook 2014-03-28 06:26:00 UTC
Ack. Sorry. Problem in my description.

I mean if "ReservesNeedReturns" is turned "OFF" it will create problems, because $found will automatically be 'W' which will turn on $already_on_shelf, which means that _koha_notify_reserve is never triggered in Reserves.pm...
Comment 2 Katrin Fischer 2014-11-21 06:55:22 UTC
*** Bug 12010 has been marked as a duplicate of this bug. ***