Summary: | Authentication using CAS - bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20266 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 17993 | ||
Attachments: |
Bug 12046: Authentication using CAS - bootstrap
[SIGNED OFF] Bug 12046: Authentication using CAS - bootstrap [PASSED QA] Bug 12046: Authentication using CAS - bootstrap Bug 12046: Authentication using CAS - bootstrap Bug 12046: Authentication using CAS - bootstrap [PASSED QA] Bug 12046: Authentication using CAS - bootstrap |
Description
Jonathan Druart
2014-04-08 14:48:22 UTC
Created attachment 26902 [details] [review] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Created attachment 26904 [details] [review] [SIGNED OFF] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Without CAS properly set up, the URL will actually be empty for the CAS' click here to login link. COMMENT: Though this does do what it says it does, would it not be better to redirect to the opac-user page and get the old page loaded up as before, so not just CAS but all potential authentication mechanisms will work? Increasing the size of the modal seems to defeat the purpose of the modal, in my opinion. Created attachment 26931 [details] [review] [PASSED QA] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. A link should be displayed, as on the opac-user.pl page (and on the prog theme). Test plan: - set opacthemes to bootstrap - enable the casAuthentication pref - fill the casServerUrl pref with "something" - go on the opac home page - click on the "log in" link (top right) - you should see 2 login blocks 'CAS' and 'Local' Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Without CAS properly set up, the URL will actually be empty for the CAS' click here to login link. COMMENT: Though this does do what it says it does, would it no be better to redirect to the opac-user page and get the old page loaded up as before, so not just CAS but all potential authentication mechanisms will work? Increasing the size of the modal seems to defeat the purpose of the modal, in my opinion. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described. This patch does not work. The variable CasServerUrl is always empty. It's a major problem for CAS users. (In reply to Fridolin SOMERS from comment #4) > This patch does not work. I've tested with a real CAS server of one of our client. It works in opac-user but not in the modal popup (link is empty) Created attachment 27618 [details] [review] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like : https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Created attachment 27628 [details] [review] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like : https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Thanks Fridolin, your patch is much more consistent than mine! Created attachment 27647 [details] [review] [PASSED QA] Bug 12046: Authentication using CAS - bootstrap At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. Test plan: - set syspref opacthemes to bootstrap - enable the casAuthentication syspref - fill the casServerUrl syspref with something like: https://localhost:8443/cas - go on the opac home page - click on "Log in to your account" link (top right) => You go to cgi-bin/koha/opac-user.pl page where you see the cas link - disable the casAuthentication syspref - go on the opac home page - click on "Log in to your account" link (top right) => You see a popup for loggin and password Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Normal login still works with/without CAS. Passes all tests and QA script. Pushed to master. Thanks, Fridolin! Pushed to 3.14.x, will be in 3.14.11 |