Summary: | Unnecessary YUI assets included in offline circ manifest | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 12118 - Unnecessary YUI assets included in offline circ manifest
Bug 12118 - Unnecessary YUI assets included in offline circ manifest [PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest |
Description
Owen Leonard
2014-04-21 17:33:55 UTC
Created attachment 27367 [details] [review] Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. I've never used the offline circulation methods. Can you use either the Firefox plugin or the desktop app? This bug is relevant only to the "Built-in offline circulation interface" (circ/offline.pl). Created attachment 27532 [details] [review] Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=11218 Created attachment 27615 [details] [review] [PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=11218 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Owen! |