Bug 12118 - Unnecessary YUI assets included in offline circ manifest
Summary: Unnecessary YUI assets included in offline circ manifest
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-21 17:33 UTC by Owen Leonard
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12118 - Unnecessary YUI assets included in offline circ manifest (1.53 KB, patch)
2014-04-21 18:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12118 - Unnecessary YUI assets included in offline circ manifest (1.60 KB, patch)
2014-04-24 12:55 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest (1.68 KB, patch)
2014-04-25 12:28 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-04-21 17:33:55 UTC
These files are not used by any page other than basketgroup.tt. They can be safely removed from the offline circ manifest.

[% themelang %]/lib/yui/button/button-min.js
[% themelang %]/lib/yui/container/container_core-min.js
[% themelang %]/lib/yui/menu/menu-min.js
[% themelang %]/lib/yui/utilities/utilities.js
Comment 1 Owen Leonard 2014-04-21 18:32:30 UTC Comment hidden (obsolete)
Comment 2 David Cook 2014-04-24 01:27:57 UTC
I've never used the offline circulation methods. Can you use either the Firefox plugin or the desktop app?
Comment 3 Owen Leonard 2014-04-24 12:31:39 UTC
This bug is relevant only to the "Built-in offline circulation interface" (circ/offline.pl).
Comment 4 Chris Cormack 2014-04-24 12:55:53 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-04-25 12:28:08 UTC
Created attachment 27615 [details] [review]
[PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest

The offline circulation asset manifest includes some YUI JavaScript
files which are no longer used by any template in Koha except for
acquisitions/basketgroup.tt. This patch removes them from the manifest.

To test, apply the patch and test offline circulation. Everything should
work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

http://bugs.koha-community.org/show_bug.cgi?id=11218

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Galen Charlton 2014-04-25 15:37:51 UTC
Pushed to master.  Thanks, Owen!