Bug 12144

Summary: Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled
Product: Koha Reporter: Kyle M Hall <kyle>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, marjorie.barry-vila, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Kyle M Hall 2014-04-25 17:23:14 UTC
When returning items with Book drop mode mode enabled and CalculateFinesOnReturn set to "calculate", the amountoutstanding for a fine, no matter how large, is reduced to 0.00

To reproduce:
1) Fine a patron with and overdue item that has fines
2) Ensure CalculateFinesOnReturn is enabled
3) Browse to the returns screen, check the "Book drop mode" but *not* the "Forgive overdue charges" box
4) Return the item
5) Check the fine for that item, it should now be reduced to 0.00
Comment 1 Jonathan Druart 2015-07-13 13:39:22 UTC
I did not manage to reproduce this bug. Could you please confirm it's fixed on master?
Comment 2 Nick Clemens (kidclamp) 2017-04-28 15:59:08 UTC
(In reply to Jonathan Druart from comment #1)
> I did not manage to reproduce this bug. Could you please confirm it's fixed
> on master?

This does exist on master under the special case of:
finesmode: Calculate and charge
CalculateFineOnReturn: enabled
cronjob fines.pl disabled

To recreate:
1 - Have an overdue with no fines yet, or backdate a checkout
2 - Check the item in with dropbox mode
3 - View the patron account - you should see a fine of amount 0 with 0 outstanding
4 - View the modification logs, fine is added and modded to 0
5 - Check the db - the last increment is the full fine

The dropbox decrements by the last increment - in this case it was lst incremented by the full fine amount.

bug 14591
bug 13044
Comment 3 Kyle M Hall 2018-12-06 14:03:43 UTC
I think the solution is to remove all the dropbox code, and make dropbox mode just be a backdated return which backdates to the last day the library was previously open.
Comment 4 Katrin Fischer 2019-02-10 12:46:35 UTC
See: Bug 13044 - Deprecate old book drop mode
Comment 5 Martin Renvoize 2019-04-03 09:40:39 UTC

*** This bug has been marked as a duplicate of bug 13044 ***