When returning items with Book drop mode mode enabled and CalculateFinesOnReturn set to "calculate", the amountoutstanding for a fine, no matter how large, is reduced to 0.00 To reproduce: 1) Fine a patron with and overdue item that has fines 2) Ensure CalculateFinesOnReturn is enabled 3) Browse to the returns screen, check the "Book drop mode" but *not* the "Forgive overdue charges" box 4) Return the item 5) Check the fine for that item, it should now be reduced to 0.00
I did not manage to reproduce this bug. Could you please confirm it's fixed on master?
(In reply to Jonathan Druart from comment #1) > I did not manage to reproduce this bug. Could you please confirm it's fixed > on master? This does exist on master under the special case of: finesmode: Calculate and charge CalculateFineOnReturn: enabled cronjob fines.pl disabled To recreate: 1 - Have an overdue with no fines yet, or backdate a checkout 2 - Check the item in with dropbox mode 3 - View the patron account - you should see a fine of amount 0 with 0 outstanding 4 - View the modification logs, fine is added and modded to 0 5 - Check the db - the last increment is the full fine The dropbox decrements by the last increment - in this case it was lst incremented by the full fine amount. See: bug 14591 bug 13044
I think the solution is to remove all the dropbox code, and make dropbox mode just be a backdated return which backdates to the last day the library was previously open.
See: Bug 13044 - Deprecate old book drop mode
*** This bug has been marked as a duplicate of bug 13044 ***