Summary: | Add new ISO code column to currency sample files | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Indranil Das Gupta <indradg> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | amitddng135, gmcharlt, indradg, jonathan.druart, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 9593 | ||
Bug Blocks: | |||
Attachments: |
Bug 12146 [ENH] Add isocode column to parameters.sql
Bug 12146 [ENH] Add isocode column to parameters.sql |
Description
Katrin Fischer
2014-04-26 15:09:21 UTC
Note that comments on bug 9593, there's a question as to whether currency.isocode should be made mandatory. Created attachment 39020 [details] [review] Bug 12146 [ENH] Add isocode column to parameters.sql a) Adds currency.isocode column to parameters.sql b) Introduces INR as an option for Koha's EN installation locale in the list of currencies Remarks: The issue of non-mandatory nature of isocode column is already settled via bug 9593, comment 77. Test Plan ========= 1/ create a fresh Koha instance and run the web installer 2/ at step #3 - "Selecting Default Settings", select "Some basic currencies with USA dollar as default for ACQ module" under the section "Optional" to import the sample currencies. 3/ login to this new instance and go to Home -> Administration -> Currencies & Exchange rates 4/ click edit for any of the currency options 5/ ISO code will be blank 6/ Apply patch 7/ Repeat steps 1 to 4 above 8/ ISO code will now show 3-letter ISO codes inserted by patched parameters.sql Bug 9593 is what added the isocode into the currency table. I figure a See Also link might be useful to have. Tweak the other currency files too. Created attachment 47281 [details] [review] Bug 12146 [ENH] Add isocode column to parameters.sql a) Adds currency.isocode column to parameters.sql b) Introduces INR as an option for Koha's EN installation locale in the list of currencies Remarks: The issue of non-mandatory nature of isocode column is already settled via bug 9593, comment 77. Test Plan ========= 1/ create a fresh Koha instance and run the web installer 2/ at step #3 - "Selecting Default Settings", select "Some basic currencies with USA dollar as default for ACQ module" under the section "Optional" to import the sample currencies. 3/ login to this new instance and go to Home -> Administration -> Currencies & Exchange rates 4/ click edit for any of the currency options 5/ ISO code will be blank 6/ Apply patch 7/ Repeat steps 1 to 4 above 8/ ISO code will now show 3-letter ISO codes inserted by patched parameters.sql Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Please provide a patch for other languages too. |