Bug 12146 - Add new ISO code column to currency sample files
Summary: Add new ISO code column to currency sample files
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Indranil Das Gupta
QA Contact: Testopia
URL:
Keywords:
Depends on: 9593
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-26 15:09 UTC by Katrin Fischer
Modified: 2022-07-20 09:39 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12146 [ENH] Add isocode column to parameters.sql (1.82 KB, patch)
2015-05-10 21:42 UTC, Indranil Das Gupta
Details | Diff | Splinter Review
Bug 12146 [ENH] Add isocode column to parameters.sql (1.87 KB, patch)
2016-01-25 21:37 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-04-26 15:09:21 UTC
Bug 9593 adds a new column for ISO code to the currency table. This column should also be added to the currency sample files.
Comment 1 Galen Charlton 2014-04-30 17:58:46 UTC
Note that comments on bug 9593, there's a question as to whether currency.isocode should be made mandatory.
Comment 2 Indranil Das Gupta 2015-05-10 21:42:48 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2015-05-11 02:17:28 UTC
Bug 9593 is what added the isocode into the currency table. I figure a See Also link might be useful to have.
Comment 4 Mark Tompsett 2015-05-16 06:01:45 UTC
Tweak the other currency files too.
Comment 5 Nick Clemens 2016-01-25 21:37:00 UTC
Created attachment 47281 [details] [review]
Bug 12146 [ENH] Add isocode column to parameters.sql

a) Adds currency.isocode column to parameters.sql
b) Introduces INR as an option for Koha's EN installation locale
   in the list of currencies

Remarks: The issue of non-mandatory nature of isocode column is
already settled via bug 9593, comment 77.

Test Plan
=========

1/ create a fresh Koha instance and run the web installer
2/ at step #3 - "Selecting Default Settings", select "Some basic
   currencies with USA dollar as default for ACQ module" under the
   section "Optional" to import the sample currencies.
3/ login to this new instance and go to Home -> Administration ->
   Currencies & Exchange rates
4/ click edit for any of the currency options
5/ ISO code will be blank
6/ Apply patch
7/ Repeat steps 1 to 4 above
8/ ISO code will now show 3-letter ISO codes inserted by patched
   parameters.sql

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Jonathan Druart 2016-01-27 11:25:36 UTC
Please provide a patch for other languages too.