Description
Nicole C. Engard
2014-05-13 12:12:55 UTC
Created attachment 28204 [details] [review] [BUG 12244] Koha 3.16 Circ Help Updates This patch updates the check in help (the only change for 3.16). To test: * Visit Circulation > Check in * Click Help * Confirm that help text is right Created attachment 28205 [details] [review] [BUG 12244] Update Patron help files for 3.16 This updates the patron help file and adds a missing help file. To test: * Go to a patron record * Click help and confirm text is correct * Go to patron's purchase suggestions * Click help and confirm that help file is there and correct Created attachment 28206 [details] [review] [BUG 12244] Update cataloging help for 3.16 This patch adds a bit to the addbiblio help file. To test: * Go to Cataloging * Click add new * Click help * Confirm help is there and correct Created attachment 28207 [details] [review] [BUG 12244] Update Search Help for 3.16 This patch updates the search help file. To test: * Visit Search * Click help * Confirm help is there and correct Created attachment 28208 [details] [review] [BUG 12244] Update Notices Help Files Updates the 2 notices help files with new info. To test: * Visit Tools > Notices & Slips * Click help and confirm it's there and right * Visit Tools > Overdue notices/status triggers * Click help and confirm it's there and right Created attachment 28209 [details] [review] [BUG 12244] Update authorized values help for 3.16 This patch adds a few new values to the authorized values help To test: * Visit Administration > Authorized Values * Click help * Confirm help is there and correct Created attachment 28210 [details] [review] [BUG 12244] Update Admin Help for 3.16 This patch updates 3 help files. To test: * Visit Administration > Patron Categories * Click help * Confirm it's there and right * Visit Administration > Currencies * Click help * Confirm it's there and right * Visit Administration > Circ Rules * Click help * Confirm it's there and right Created attachment 28211 [details] [review] [BUG 12244] Update Acq Help for 3.16 This updates the basket help. To test: * Open a basket * Click help and confirm it's right and there I'm sure there are more, but these are the big changes that hopefully can be in Koha 3.16. Nicole Created attachment 28219 [details] [review] [SIGNED-OFF] Bug 12244 - Koha 3.16 Circ Help Updates This patch updates the check in help (the only change for 3.16). To test: * Visit Circulation > Check in * Click Help * Confirm that help text is right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help is right Created attachment 28220 [details] [review] [SIGNED-OFF] Bug 12244 - Update Patron help files for 3.16 This updates the patron help file and adds a missing help file. To test: * Go to a patron record * Click help and confirm text is correct * Go to patron's purchase suggestions * Click help and confirm that help file is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both text are correct, link still points to 3.14 manual, but depends on a value that must change with new release. Created attachment 28221 [details] [review] [SIGNED-OFF] Bug 12244 - Update cataloging help for 3.16 This patch adds a bit to the addbiblio help file. To test: * Go to Cataloging * Click add new * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help is ok Created attachment 28222 [details] [review] [SIGNED-OFF] Bug 12244 - Update Search Help for 3.16 This patch updates the search help file. To test: * Visit Search * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok Created attachment 28223 [details] [review] [SIGNED-OFF] Bug 12244 - Update Notices Help Files Updates the 2 notices help files with new info. To test: * Visit Tools > Notices & Slips * Click help and confirm it's there and right * Visit Tools > Overdue notices/status triggers * Click help and confirm it's there and right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Long help ok Created attachment 28224 [details] [review] [SIGNED-OFF] Bug 12244 - Update authorized values help for 3.16 This patch adds a few new values to the authorized values help To test: * Visit Administration > Authorized Values * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> New values ok Created attachment 28225 [details] [review] [SIGNED-OFF] Bug 12244 - Update Admin Help for 3.16 This patch updates 3 help files. To test: * Visit Administration > Patron Categories * Click help * Confirm it's there and right * Visit Administration > Currencies * Click help * Confirm it's there and right * Visit Administration > Circ Rules * Click help * Confirm it's there and right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok. One comment: on circ rules, I think that "you're" can be correct, but I prefer "you are" Created attachment 28226 [details] [review] [SIGNED-OFF] Bug 12244 - Update Acq Help for 3.16 This updates the basket help. To test: * Open a basket * Click help and confirm it's right and there http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok Final comment: koha-qa complains about tabs, removed in followup Created attachment 28227 [details] [review] Bug 12244 - followup to fix tabs Only tab removing Created attachment 28234 [details] [review] Bug 12244 - Koha 3.16 Circ Help Updates This patch updates the check in help (the only change for 3.16). To test: * Visit Circulation > Check in * Click Help * Confirm that help text is right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help is right Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28235 [details] [review] Bug 12244 - Update Patron help files for 3.16 This updates the patron help file and adds a missing help file. To test: * Go to a patron record * Click help and confirm text is correct * Go to patron's purchase suggestions * Click help and confirm that help file is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both text are correct, link still points to 3.14 manual, but depends on a value that must change with new release. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28236 [details] [review] Bug 12244 - Update cataloging help for 3.16 This patch adds a bit to the addbiblio help file. To test: * Go to Cataloging * Click add new * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help is ok Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28237 [details] [review] Bug 12244 - Update Search Help for 3.16 This patch updates the search help file. To test: * Visit Search * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28238 [details] [review] Bug 12244 - Update Notices Help Files Updates the 2 notices help files with new info. To test: * Visit Tools > Notices & Slips * Click help and confirm it's there and right * Visit Tools > Overdue notices/status triggers * Click help and confirm it's there and right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Long help ok Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28239 [details] [review] Bug 12244 - Update authorized values help for 3.16 This patch adds a few new values to the authorized values help To test: * Visit Administration > Authorized Values * Click help * Confirm help is there and correct http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> New values ok Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28240 [details] [review] Bug 12244 - Update Admin Help for 3.16 This patch updates 3 help files. To test: * Visit Administration > Patron Categories * Click help * Confirm it's there and right * Visit Administration > Currencies * Click help * Confirm it's there and right * Visit Administration > Circ Rules * Click help * Confirm it's there and right http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok. One comment: on circ rules, I think that "you're" can be correct, but I prefer "you are" Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28241 [details] [review] Bug 12244 - Update Acq Help for 3.16 This updates the basket help. To test: * Open a basket * Click help and confirm it's right and there http://bugs.koha-community.org/show_bug.cgi?id=12244 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Help ok Final comment: koha-qa complains about tabs, removed in followup Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 28242 [details] [review] Bug 12244 - followup to fix tabs Only tab removing Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Suggestions: (In reply to Nicole C. Engard from comment #3) > Created attachment 28206 [details] [review] [review] The value of the "Show tags" checkbox is stored in a cookie. So the system preference is only checked at the first access, to retrieve a default value. (In reply to Nicole C. Engard from comment #5) > Created attachment 28208 [details] [review] [review] > Important: When working with the overdue notices you want each notice at each branch to have a unique code. Think about using the branch code in front of the notice code for each branch. Yes, this is very important! I submitted a patch (bug 11742) to alert the user when he tries to insert a duplicated letter code. I hope it will be integrated into 3.16 To delete templates in letters.pl, you can delete the entry in the message_transport_types table. For instance, afaik, deleting "feed" does not cause problem. Maybe it could be good to add that a print notice is generated if no notice can be generated. Marked as Passed QA. Pushed to master. Thanks, Nicole! |