Summary: | Update descriptions for languages, scripts and regions | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, nengard, novamcccharles, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 13328 | ||
Attachments: |
Bug 12250 - Add Kurdish Language
Bug 12250: Update descriptions for languages, scripts and regions Bug 12250: Update descriptions for languages, scripts and regions [PASSED QA] Bug 12250: Update descriptions for languages, scripts and regions |
Description
Bernardo Gonzalez Kriegel
2014-05-13 19:48:28 UTC
Created attachment 28217 [details] [review] Bug 12250 - Add Kurdish Language This patch adds Kurdish language As a side effect, it put in sync with english all language versions of subtag_registry.sql To test: 1. Apply the patch 2. Run updatedatabase.pl 2.b Test loading new subtag_registry.sql run on database: delete from language_descriptions; delete from language_rfc4646_to_iso639; delete from language_script_bidi; delete from language_script_mapping; delete from language_subtag_registry; load subtag_registry.sql 3. Update/Install ku-Arab cd misc/translator perl translate update ku-Arab perl translate install ku-Arab 4. Go to Sysprefs > I18N, check correct Kurdish description 5. Enable kurdish on opac/staff, enable opaclanguagesdisplay 6. Reload staff, change to Kurdish, check correct RTL display 7. Reload opac, change to Kurdish, chech correct RTL display Note: As Kurdish has two descriptions based on script type, I added both because can't select description based only on language code 'ku' Sounds great. Just a question, should the description always be in plain text or in HTML-encoded ? For example the patch adds : VALUES( 'lo', 'language', 'lo', 'ພາສາລາວ'); (In reply to Fridolin SOMERS from comment #2) > Just a question, should the description always be in plain text or in > HTML-encoded ? > For example the patch adds : > VALUES( 'lo', 'language', 'lo', > 'ພາສາລາວ'); That value and similar ones are present on EN version of file, not added by me. I prefer plain text, and have a patch to complete/update language descriptions. But also have Bug 12017 to remove language descriptions from database. Until I get a comment on it (against or for), I will not update lang descriptions on database, but anyone can :) Changing description to reflect broader scope Created attachment 33127 [details] [review] Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 *** Bug 5686 has been marked as a duplicate of this bug. *** Created attachment 33329 [details] [review] Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 33348 [details] [review] [PASSED QA] Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested the SQL, no problems found. Patch pushed to master. Thanks Bernardo! *** Bug 13015 has been marked as a duplicate of this bug. *** |