Description
Fridolin Somers
2014-05-20 10:37:29 UTC
Created attachment 28347 [details] [review] Bug 12291 - remove acronym for CAS (bootstrap) The HTML tag acronym is obsolete for HTML5 and also complicates translation. In sources : <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, It generates : msgid "If you have a " msgid "Central Authentication Service" msgid "account, %s please " This is difficult to translate correctly because strings are splitted. For example in French, the translation is actually : msgid "Si vous avez un " msgid "Central Authentication Service (Service d'Identification Centralisé)" msgid "compte, %s s'il vous plait " It generates : <p>Si vous avez un <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym> compte, %s s'il vous plait. It should be : <p>Si vous avez un compte <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym>, %s s'il vous plait. This patch removes the acronym tag and moves the title attribute to the h4 tag. Test plan : - Enable OPAC bootstrap theme - Enable casAuthentication - Go to login page /cgi-bin/koha/opac-user.pl => Without patch you see "If you have a CAS account", CAS is a acronym tag. => With patch you see "If you have a CAS account" without acronym tag and "CAS login" has a title "Login via Central Authentication Service" Created attachment 28348 [details] [review] Bug 12291 - remove acronym for CAS (prog) The patch doesn't work completely we correctly apply bootstrap theme and cas authentication goto the opac login page The acronym is still there; The h4 title is correctly modified but the display is not effective, the acronym is still there <!--CONTENT--> <!-- login prompt time--> <h3> … </h3> <h4 title="Login via Central Authentication Service"> Identification par CAS </h4> (In reply to pierre.lorgue from comment #3) > The patch doesn't work completely Thanks for testing. I see your text is in french. You must test in "en" language, meaning without translation. Comment on attachment 28348 [details] [review] Bug 12291 - remove acronym for CAS (prog) Since the prog theme has been deleted, this patch is not needed anymore. Fridolin, this should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Created attachment 36064 [details] [review] Bug 12291: Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. Created attachment 36569 [details] [review] Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of <acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining <acronym>, in acqui/parcels.tt. I sign off this patch and will provide a followup for the last occurrence. Created attachment 36572 [details] [review] Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. Created attachment 36574 [details] [review] Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 36580 [details] [review] [PASSED QA] Bug 12291: [SIGNED-OFF] Replace acronym with tag at the OPAC On the OPAC authentification page, the acronym tag is used, but deprecated. It should be replaced with abbr: http://www.w3.org/wiki/HTML/Elements/acronym Test plan: Enable the CAS authentification and verify the tags have correctly been replaced. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Befor the patch, "grep -r "<acronym" koha-tmpl/*/*/en/*" shows 4 occurences of <acronym>, 3 related to CAS. After the patch, the same grep shows 1 remaining <acronym>, in acqui/parcels.tt. I sign off this patch and will provide a followup for the last occurrence. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 36581 [details] [review] [PASSED QA] Bug 12291 - Replace the acronym HTML tag with abbr - FOLLOWUP This patch replaces the last occurrence of <acronym> with <abbr>. To test: - Apply this patch on top of the first patch and check that "grep -r "<acronym" koha-tmpl/*/*/en/*" does not return any hits. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Thanks Jonathan and Magnus! Pushed to 3.18.x will be in 3.18.6 |