Bug 12295

Summary: Javascript error when merging authorities
Product: Koha Reporter: Kyle M Hall <kyle>
Component: CatalogingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: bgkriegel, francois.charbonnier, fridolin.somers, gmcharlt, m.de.rooy, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 36659    
Attachments: Bug 12295 - Javascript error when merging authorities
[SIGNED-OFF] Bug 12295 - Javascript error when merging authorities
Bug 12295: fix Javascript error when merging authorities
Bug 12295: fix Javascript error when merging authorities

Description Kyle M Hall 2014-05-20 18:57:53 UTC
Attempting to merge authorities results in the following error:
Uncaught SyntaxError: Unexpected token u authorities-home.pl:284
    showMergingInProgress authorities-home.pl:284
    (anonymous function) authorities-home.pl:297
    o jquery.js:2
    p.fireWith jquery.js:2
    e.extend.ready jquery.js:2
    c.addEventListener.B
Comment 1 Kyle M Hall 2014-05-20 19:01:00 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-05-21 10:16:50 UTC
Upgrading importance to major considering that this breaks authorities merging.
Comment 3 Bernardo Gonzalez Kriegel 2014-05-27 19:37:44 UTC Comment hidden (obsolete)
Comment 4 Galen Charlton 2014-05-27 21:03:27 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2014-05-27 21:11:00 UTC
Created attachment 28501 [details] [review]
Bug 12295: fix Javascript error when merging authorities

Attempting to merge authorities results in the following error:
Uncaught SyntaxError: Unexpected token u authorities-home.pl:284
    showMergingInProgress authorities-home.pl:284
    (anonymous function) authorities-home.pl:297
    o jquery.js:2
    p.fireWith jquery.js:2
    e.extend.ready jquery.js:2
    c.addEventListener.B

This was the result of the upgrade of jquery-cookie by the patch
for bug 11369; newer versions of jquery-cookie changed the return of
$.cookie('foo') from null to undefined when the cookie is not present.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No test plan, no errors.

Test
1. search some authorities
2. click merge, on browser dev console pops reported error message
'Unexpected token u authorities-home.pl...'
No way to marge auths
3. with pach applied, merging works again

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Comment 6 Tomás Cohen Arazi 2014-06-05 15:18:26 UTC
Pushed to master.

Thanks Kyle!
Comment 7 Galen Charlton 2014-06-05 15:33:39 UTC
Pushed to 3.16.x for inclusion in 3.16.1.
Comment 8 Janusz Kaczmarek 2014-07-15 21:45:28 UTC
*** Bug 12579 has been marked as a duplicate of this bug. ***
Comment 9 Fridolin Somers 2014-07-22 08:04:18 UTC
Pushed to 3.14.x, will be in 3.14.09