| Summary: | Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | OPAC | Assignee: | Olli-Antti Kivilahti <olli-antti.kivilahti> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cbrannon, gwilliams, lisettepalouse+koha, marianne.rolfsen, olli-antti.kivilahti, techservspec, tmisilo, tomascohen, tubaclarinet, victoria.kemp |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 |
||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12917 | ||
| Bug Blocks: | |||
| Attachments: |
Initial commitmonster
Bug-12353-Everybody-needs-to-know-the-last-pickup-da.patch Bug 12353 - Last pickup date in the letter templates Bug 12353 - Displaying the last pickup date in OPAC and staff client and waitingholds.pl Bug 12353 - cancel_expired_holds.pl -cronjob respects last pickup date |
||
|
Description
paxed
2014-06-03 04:44:22 UTC
Would like to see this date on the staff side too. Christopher Created attachment 31556 [details] [review] Initial commitmonster When calculating the last date before reserve expires, skip all days marked as holidays. This is done in C4::Reserves::_reserve_last_pickup_date() and Koha::Reserves::GetLastpickupdate() Also cronjobs/holds/delete_expired_holds.pl and circ/waitingreserves.pl are modified to use these routines, instead of each using their own method of determining last pickup date. Add a new <<lastpickupdate>> marker usable in RESERVESLIP and HOLD. Display the last pickup date in member/moremember.pl and circ/circulation.pl and circ/waitingreserves.pl opac/opac-user.pl Refactored paxed's and seppalaj's work to work with 3.16.3. I hope you sign this off Christopher! Created attachment 31572 [details] [review] Bug-12353-Everybody-needs-to-know-the-last-pickup-da.patch Created attachment 31584 [details] [review] Bug 12353 - Last pickup date in the letter templates Bug 12353 - Last pickup date in the letter templates TEST PLAN: PREPARE THE LETTER: 1. Go to Home › Tools › Notices & Slips. 2. Edit letter template with code HOLD. 3. Add the <<lastpickupdate>> placeholder to different template types. SEND AND RECEIVE THE LETTER: 1. Create a reservation for a Borrower with pickup branch. 2. Make sure the borrower receives "Hold waiting for pickup"-notices using the message _transport_Type on which you added the <<lastpickupdate>> -placeholder. 3. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 4. Wait for the message to be delivered and observe your <<lastpickupdate>> being replaced with a date. Created attachment 31585 [details] [review] Bug 12353 - Displaying the last pickup date in OPAC and staff client and waitingholds.pl Bug 12353 - Displaying the last pickup date in OPAC and staff client and waitingholds.pl TEST PLAN: 1. Create a reservation for a Borrower with pickup branch 2. Check-in the corresponding Item in the pickup branch and confirm the hold for the Borrower 3. Go to circ/circulation.pl for the Borrower and verify that the reservation is "Waiting for pickup" 4. In the Home › Circulation › Checkouts -tab (circ/circulation.pl) and in the Home › Patrons › Patron details -tab and in the OPAC your summary and in the circ/waitingreserves.pl When looking at reserves, you will find a last pickup date -column added which has a value if the reservation is waiting for pickup. Created attachment 31586 [details] [review] Bug 12353 - cancel_expired_holds.pl -cronjob respects last pickup date Bug 12353 - cancel_expired_holds.pl -cronjob respects last pickup date Make sure to test with unicode material! Please, make sure the functinality changes you introduce get proper unit tests. Hi Olli-Antti, a few things that have me confused here: 1) Can you please explain how your patches are different to bug 8735? I think we can't have different solutions on master and in 3.16 - this would not make much sense. :) 2) Please only send patches against master, if it's not a problem that only appears in a lower version. Patches don't apply. 3) I think this is somewhere in a grey zone, but more an enh than a bugfix, so should not be for 3.16, but for 3.18. The new placeholder is more like a 'small new feature' than a bugfix. 4) Some of the last pickup dates in the templates use the TT Dates plugin, others don't. Thanks for the review Katrin! Olli-Antti, I did not get notified of your patch. I will take a look at it when you address the things already in question. Christopher (In reply to Katrin Fischer from comment #11) > Hi Olli-Antti, > > a few things that have me confused here: > > 1) Can you please explain how your patches are different to bug 8735? Katrin, I don't think this has anything to do with 8735. 8735 addresses the expired date falling on holidays. Was there a different bug you meant to refer to? Christopher (In reply to Christopher Brannon from comment #14) > (In reply to Katrin Fischer from comment #11) > > Hi Olli-Antti, > > > > a few things that have me confused here: > > > > 1) Can you please explain how your patches are different to bug 8735? > > Katrin, > I don't think this has anything to do with 8735. 8735 addresses the expired > date falling on holidays. Was there a different bug you meant to refer to? > > Christopher Katrin, Ignore me. Didn't see the holidays modifications. :/ I've been off for 4 days. Can you tell? Christopher 4 days are forever in terms of Koha :) Hope you had a good time! I was not sure how it all fits together, hoping that Olli can explain. I didn't know of Bug 8735 when I refactored others work and shared this featureset we have. I think that bug is very similar, except this bug introduces more stuff. Do as you please with this, maybe it helps someone else who is looking for the same features to use this code. As an important difference this feature removes code duplication regarding holds expiration from 3 different places and centralizes it to actual functions. I was about to file a bug for the holds calculated expiration date not caring about the calendar (calculate ReservesMaxPickUpDelay in opening days vs. calendar days), but will leave a not here instead. This bug seems to have a wider scope tho. Flower Mound Public Library has noticed that reserves DO NOT TAKE INTO ACCOUNT closed holidays. What exactly is the point of marking up a calendar if the software does not know what to do with it. That is nuts. We have been live on Koha for four and a half months now and during both Thanksgiving and now Christmas the closed days are not being accounted for in the holds. Please, someone, figure out how to make this work. Wondering if we should change this to a bug report instead of enh. We have the same problem at Oslo public library. Would very much like to fix this! I think the notices are ok, as the pick-up date is in reserves.expirationdate. But we still need to fix the problem with the calendar. Maybe this was fixed by bug 12063? *** This bug has been marked as a duplicate of bug 12063 *** |