Summary: | News does not always display in staff or OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | MetaBiblioteca Colombia <felipe.gomez3> |
Component: | Tools | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, katrin.fischer, kyle, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 12507 - Don't show News in Staff and opac
Bug 12507 - News does not always display in staff or OPAC [SIGNED-OFF] Bug 12507 - News does not always display in staff or OPAC [PASSED QA] Bug 12507 - News does not always display in staff or OPAC |
Description
MetaBiblioteca Colombia
2014-07-01 03:53:31 UTC
Please paste the error. The news feature works fine for me in the OPAC and staff client in version 3.16.01. I can confirm this bug. There is no error message in the logs! Created attachment 30410 [details] [review] Bug 12507 - Don't show News in Staff and opac I have no idea how to trigger this bug, but the tester can at least prove it does not cause a regression, I think that should be enough! Created attachment 30411 [details] [review] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Created attachment 30412 [details] [review] [SIGNED-OFF] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Signed-off-by: Owen Leonard <oleonard@myacpl.org> Many Thanks for this patch Created attachment 30499 [details] [review] [PASSED QA] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Ideally this should have a regression test, but I am not sure how to pretend a specific date for the test to work as it's using SQL to get the current date. Patch pushed to master. Thanks Kyle! Pushed to 3.16.x, will be in 3.16.10 (In reply to Mason James from comment #11) > Pushed to 3.16.x, will be in 3.16.10 Fridolyn, you might want this for 3.14.x? |