|
Description
Iming Chan
2014-07-06 11:37:11 UTC
+1 ! I add that a marc21 view would be helpful too. Regards, Marjorie Created attachment 86199 [details] [review] Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Created attachment 88774 [details] [review] Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> Created attachment 88776 [details] [review] Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> Comment on attachment 88776 [details] [review] Bug 12533: Improve authority search result display Review of attachment 88776 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc @@ -56,2 @@ > [% BLOCK authresult %] > - [% IF ( summary.label ) %][% summary.label | html %]:[% END %] This all seems to work well, but i am in doubt about this line here. I think the summary feature is only used by UNIMARC, but are we sure this has no side effects? I've tried this: http://koha.1045719.n5.nabble.com/Authority-Type-Help-in-Koha-td3062760.html But didn't seem to get it to work. I Notice it displays on top without getting interpreted. Can you have a look? Created attachment 112104 [details] [review] Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> (In reply to Katrin Fischer from comment #6) > > [% BLOCK authresult %] > > - [% IF ( summary.label ) %][% summary.label | html %]:[% END %] I should have submitted this as a followup but I got lost during rebasing. This change has been removed. Overall I like the changes, but could we improve readability of the modal a bit with CSS? At the moment the text all flows together and it's hard to distinguish labels and content. Created attachment 112175 [details]
Screenshot of new modal in authority linker
Created attachment 112183 [details] [review] Bug 12533: (follow-up) Add CSS to preview display of authority MARC This patch adds the same CSS used by authorities/detail.tt to the modal preview of the authority record shown in the authorities search result popup. Created attachment 112185 [details] [review] Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 112186 [details] [review] Bug 12533: (follow-up) Add CSS to preview display of authority MARC This patch adds the same CSS used by authorities/detail.tt to the modal preview of the authority record shown in the authorities search result popup. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |