Bug 12534

Summary: PROG/CCSR deprecation: Make getlanguages() theme independent for opac
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: I18N/L10NAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: f.demians, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 11346    
Attachments: Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac
[PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac

Description Bernardo Gonzalez Kriegel 2014-07-07 00:01:04 UTC
getlanguages() function on C4/Languages.pm has a hardcoded reference to 'prog'
Comment 1 Bernardo Gonzalez Kriegel 2014-07-07 00:19:07 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-07 17:24:46 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi (tcohen) 2014-07-10 14:21:44 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall (khall) 2014-07-11 13:34:03 UTC
Created attachment 29641 [details] [review]
[PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac

This patch removes a reference to prog theme on getlanguages()
when ENV var HTTP_ACCEPT_LANGUAGE is checked.

Changed to use sysprefs to find theme for opac and intranet

To test:
1) Apply the patch
2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc
3) Enable those languages for OPAC on I18N prefs
4) Using Firefox, clean all history/cookies
5) Change variable intl.accept_languages (will do several times)
 a) got to about:config
 b) search 'lang'
 c) look for the variable, double click, change to 'de-DE'
6) Go to opac page, must load in german
7) Repeat for each translated lang: clean > change val > reload opac
   On each case opac must load on configured language
8) Just to test, set variable on untranslated lang, opac page
must load on first value of list of enabled languages
9) prove t/Languages.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2014-07-14 12:01:46 UTC
Patch pushed to master.

Thanks Bernardo!