getlanguages() function on C4/Languages.pm has a hardcoded reference to 'prog'
Created attachment 29533 [details] [review] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() for opac when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use 'opacthemes' syspref. To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t
Created attachment 29555 [details] [review] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t
Created attachment 29608 [details] [review] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 29641 [details] [review] [PASSED QA] Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for opac This patch removes a reference to prog theme on getlanguages() when ENV var HTTP_ACCEPT_LANGUAGE is checked. Changed to use sysprefs to find theme for opac and intranet To test: 1) Apply the patch 2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc 3) Enable those languages for OPAC on I18N prefs 4) Using Firefox, clean all history/cookies 5) Change variable intl.accept_languages (will do several times) a) got to about:config b) search 'lang' c) look for the variable, double click, change to 'de-DE' 6) Go to opac page, must load in german 7) Repeat for each translated lang: clean > change val > reload opac On each case opac must load on configured language 8) Just to test, set variable on untranslated lang, opac page must load on first value of list of enabled languages 9) prove t/Languages.t Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Bernardo!