|
Description
Jonathan Druart
2014-07-07 14:44:07 UTC
Created attachment 29551 [details] [review] Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Hi, it is not to coordinate this bug with 12478 ? I think it will need to take 12478 into consideration, the code for which is in a public branch already. But I dont think this is contigent on that, it just should make sure that removing the Solr code doesnt break the Elasticsearch stuff Yes, for example bug 12478 uses the system preference 'SearchEngine' I wonder if Moose should be removed from C4/Installer/PerlDependencies.pm as well? Was it used anywhere else but in the Solr stuff? As for removing Solr code breaking ElasticSearch stuff, I'd love to hear Robin weigh in. I imagine it might be an idea to keep the system preference (while removing the Solr reference) and perhaps that's it. I imagine the search engine switching in the current ES code could be updated to use a new model. There's very little overlap between them really, I'd be more inclined to have Jonathan remove everything, and I'll go through and un-revert the bits I want to keep. (In reply to Robin Sheat from comment #6) > There's very little overlap between them really, I'd be more inclined to > have Jonathan remove everything, and I'll go through and un-revert the bits > I want to keep. +1 (In reply to Robin Sheat from comment #6) > There's very little overlap between them really, I'd be more inclined to > have Jonathan remove everything, and I'll go through and un-revert the bits > I want to keep. So, back to needs signoff Created attachment 31817 [details] [review] Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 31818 [details] [review] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies Created attachment 31819 [details] [review] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 31993 [details] [review] [PASSED QA] Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 31994 [details] [review] [PASSED QA] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Jonathan! Created attachment 32281 [details] [review] Bug 12538: one more file left Followup pushed to master. Thanks Jonathan. |