Summary: | Exporting report as Open Document Spreadsheet results in Perl error when report has no results | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, karamqubsi, nengard, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12888 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 11679 | ||
Bug Blocks: | |||
Attachments: |
Bug 12622: Fix export report as ods
Signed off patch [PASSED QA] Bug 12622: Fix export report as ods |
Description
Katrin Fischer
2014-07-22 07:47:42 UTC
Created attachment 29952 [details] [review] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Created attachment 30067 [details] [review] Signed off patch Other exported report types seem to work with queries that produce no results Created attachment 30074 [details] [review] [PASSED QA] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Signed-off-by: Robert Higgins <robert.higgins@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the reported problem, passes all tests and QA script. Added the sign-off line for Robert. Resetting Assigned to to Jonathan - as he is the patch writer. Thx for testing Robert! Patch pushed to master. Thanks Jonathan! Pushed to 3.16.x for inclusion in 3.16.3. *** Bug 13010 has been marked as a duplicate of this bug. *** |