Summary: | Software error when trying to merge records from different frameworks | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Cataloging | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, julian.maurice, m.de.rooy, ztajoli |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Screen shot of record merge.
Bug 12629 - Software error when trying to merge records from different frameworks Bug 12629 - Software error when trying to merge records from different frameworks Bug 12629 - Software error when trying to merge records from different frameworks |
Created attachment 30007 [details] [review] Bug 12629 - Software error when trying to merge records from different frameworks Test Plan: 1) Choose a bib record that has the default framework. 2) Add a second record using that fast add framework. 3) Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. 4) Apply this patch 5) Repeat steps 1 - 3, no error should occur This bug has had a patch since 2014 but was never marked "Needs signoff!" However, I can't reproduce the problem in master. Is it still valid? (In reply to Owen Leonard from comment #2) > This bug has had a patch since 2014 but was never marked "Needs signoff!" > However, I can't reproduce the problem in master. Is it still valid? Looking at the code, I'd say it's still valid and appears when a field is defined in one framework but in the other one. Created attachment 55386 [details] [review] Bug 12629 - Software error when trying to merge records from different frameworks Test Plan: 1) Choose a bib record that has the default framework. 2) Add a second record using that fast add framework. 3) Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. 4) Apply this patch 5) Repeat steps 1 - 3, no error should occur Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> I do not recreate the error. Is there something missing in the test plan? Try to test using 006 or 007 in record with 'Default' framework. Tags 006 and 007 are nt defined in FA framework and are minus than 10. Created attachment 55525 [details] [review] Bug 12629 - Software error when trying to merge records from different frameworks Test Plan: 1) Choose a bib record that has the default framework. 2) Add a second record using that fast add framework. 3) Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. 4) Apply this patch 5) Repeat steps 1 - 3, no error should occur Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Zeno Tajoli from comment #6) > Try to test using 006 or 007 in record with 'Default' framework. > Tags 006 and 007 are nt defined in FA framework and are minus than 10. Indeed, thanks! Pushed to master for 16.11! Pushed in 16.05. Will be in 16.05.04. Pushed to 3.22.x, will be in 3.22.11 |
Created attachment 29960 [details] Screen shot of record merge. Software error: Can't use string ("") as a HASH ref while "strict refs" in use at /var/lib/koha/butte/kohaclone/Koha/Util/MARC.pm line 46. To re-create: Choose a bib record that has the default framework. Add a second record using that fast add framework. Merge the records; switch to "Using framework: Default", and choose the original record (i.e. the one that had the default framework) as the merge reference. Clicking 'Next' will trigger the error. See attached screenshot.