Summary: | Markup improvements to holds awaiting pickup report | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/waitingreserves.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12523 | ||
Bug Blocks: | |||
Attachments: |
Bug 12692 - Markup improvements to holds awaiting pickup report
Bug 12692 - Markup improvements to holds awaiting pickup report [PASSED QA] Bug 12692 - Markup improvements to holds awaiting pickup report |
Description
Owen Leonard
2014-08-01 18:04:32 UTC
Created attachment 30469 [details] [review] Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly Created attachment 32734 [details] [review] Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described: subtitle displayes (if mapping defined), library name instead of code, and email as clickable mailto. Remark 1: As for bug 13083, subtitle display is not as good in UNIMARC than in MARC21, since subtitle is not separated from title by ':'. Remark 2: 'subtitle' field is retrieved from a field mapping. Taking a look at C4::Biblio::GetRecordValue, one see that the fieldmapping is directly queried. There isn't any caching system, like for frameworks. Created attachment 32737 [details] [review] [PASSED QA] Bug 12692 - Markup improvements to holds awaiting pickup report This patch makes some minor updates to the output of the holds awaiting pickup report. To test you should have several holds which are marked as "waiting," including some which have been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. - Go to Circulation -> Holds awaiting pickup - In both the "waiting" and "over" tabs, confirm that titles display any associated subtitle - Confirm that library name is shown instead of library code - Confirm that the patron name mailto: link works correctly Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described: subtitle displayes (if mapping defined), library name instead of code, and email as clickable mailto. Remark 1: As for bug 13083, subtitle display is not as good in UNIMARC than in MARC21, since subtitle is not separated from title by ':'. Remark 2: 'subtitle' field is retrieved from a field mapping. Taking a look at C4::Biblio::GetRecordValue, one see that the fieldmapping is directly queried. There isn't any caching system, like for frameworks. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and passes tests and QA script. Patch pushed to master. Thanks Owen! |