Bug 12692 - Markup improvements to holds awaiting pickup report
Summary: Markup improvements to holds awaiting pickup report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/circ/waitingreserves.pl
Keywords:
Depends on: 12523
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-01 18:04 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12692 - Markup improvements to holds awaiting pickup report (7.36 KB, patch)
2014-08-01 18:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12692 - Markup improvements to holds awaiting pickup report (7.83 KB, patch)
2014-10-25 15:52 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 12692 - Markup improvements to holds awaiting pickup report (7.95 KB, patch)
2014-10-25 18:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-08-01 18:04:32 UTC
Proposed changes:

- add output of subtitle
- correct output of email address
- fix some formatting issues
- output library name instead of code
Comment 1 Owen Leonard 2014-08-01 18:24:24 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-10-25 15:52:28 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-25 18:38:22 UTC
Created attachment 32737 [details] [review]
[PASSED QA] Bug 12692 - Markup improvements to holds awaiting pickup report

This patch makes some minor updates to the output of the holds awaiting
pickup report. To test you should have several holds which are marked as
"waiting," including some which have been waiting longer than the number
of days specified in the ReservesMaxPickUpDelay system preference.

- Go to Circulation -> Holds awaiting pickup
- In both the "waiting" and "over" tabs, confirm that titles display any
  associated subtitle
- Confirm that library name is shown instead of library code
- Confirm that the patron name mailto: link works correctly

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

Works as described: subtitle displayes (if mapping defined), library name
instead of code, and email as clickable mailto.

Remark 1: As for bug 13083, subtitle display is not as good in UNIMARC than in
MARC21, since subtitle is not separated from title by ':'.

Remark 2: 'subtitle' field is retrieved from a field mapping. Taking a look at
C4::Biblio::GetRecordValue, one see that the fieldmapping is directly queried.
There isn't any caching system, like for frameworks.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described and passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-11-10 15:57:11 UTC
Patch pushed to master.

Thanks Owen!