Bug 12694

Summary: Remove CGI::scrolling_list from unimarc_field_4XX.pl
Product: Koha Reporter: Bernardo Gonzalez Kriegel <bgkriegel>
Component: TemplatesAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 766    
Attachments: Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl
Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl
[PASSED QA] Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl

Description Bernardo Gonzalez Kriegel 2014-08-02 01:16:18 UTC
Two on this file
Comment 1 Bernardo Gonzalez Kriegel 2014-08-02 01:27:41 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-08-08 03:01:57 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-17 10:20:35 UTC
Created attachment 30895 [details] [review]
[PASSED QA] Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl

There are two instances on this file, but they are not used.
I suppose is old code that was left dangling.

Both scrolling_list, CGIPublisher and CGIitemtype, are not
used on unimarc_field_4XX.tt nor any other file.

Just removed from file two useless db queries.

To test:
1. Apply the patch
2. If you have unimarc config, just go to one of the
fields that use this plugin.
If you don't, can edit you framework and change the plugin
for a tag, e.g. 007. Then save fw, search and edit a record,
clic to open plugin on 007 tag, check that works but don't
save the original record, finally revert your changes.

There must be no functional changes, is unused code.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Verified plugin still seems to work:
- item type pull down shows up correctly
- search works and choosing a record will fill subfields
Passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-08-19 15:54:37 UTC
Patch pushed to master.

Thanks Bernardo!