| Summary: | Remove CGI::scrolling_list from marc21_linking_section.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Component: | Templates | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 766 | ||
| Attachments: |
Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl
[SIGNED-OFF] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl [PASSED QA] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl |
||
|
Description
Bernardo Gonzalez Kriegel
2014-08-02 01:48:24 UTC
Created attachment 30476 [details] [review] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Created attachment 30771 [details] [review] [SIGNED-OFF] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. The behavior of the plugin window appears to be unchanged after applying the patch. Created attachment 30861 [details] [review] [PASSED QA] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. The behavior of the plugin window appears to be unchanged after applying the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amending the test plan a bit: The plugin was added by bug 8185 - not dead code at all :) In order to test: - Edit one of your frameworks, make 773 atwxz9 visible. - Link 773 $9 to the marc21-linking-section plugin - Create a new record in cataloguing - Search for a your host item record (parent) - Link it - Observe that the subfields have been filled with information from the other record $w = 001 from the parent $9 = biblionumber from the parent $t = Title $x = ISSN ... Still works with the patch applied. Patch pushed to master. Thanks Bernardo! |