| Summary: | Remove CGI::scrolling_list from C4/Reports.pm | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Component: | Templates | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 766, 12706, 12707 | ||
| Attachments: |
Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm
[Signed-off] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm [PASSED QA] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm |
||
|
Description
Bernardo Gonzalez Kriegel
2014-08-02 02:06:19 UTC
Created attachment 30477 [details] [review] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm This patch removes only instance in this file. Problem is that there are many template files involved. Most of them have other instances of scrolling_lists but is a problem for other bugs, they will depend on this. What is replaced is a pulldown for delimiter choices. In all but one case the code is the same (variable name change), and I did a little tidy of the TT code To test: 1. Apply the patch In all the following cases, check delimiters pulldown (Output box, bottom right) 2. Go to Reports > Statistics wizard > Acquisitions 3. Go to Reports > Statistics wizard > Patrons 4. Go to Reports > Statistics wizard > Catalog 5. Go to Reports > Statistics wizard > Circulation 6. Go to Reports > Statistics wizard > Serials 7. Go to Reports > Statistics wizard > Holds there is a bug here, pulldown next to this must show 'CSV' option, but shows nothing. Will be fixed 8. Go to Reports > Other > Average loan time 9. Go to Reports > Top lists > Patron checking out the most Here there is a 'Delimiter' label before delimiters, only case 10. Go to Reports > Top lists > Most-circulated items 11. Go to Reports > Inactive > Patrons who haven't checked out There is and inconsistency here, name of option on reports page, and name on this report, 'Patrons with no checkouts' Created attachment 30541 [details] [review] [Signed-off] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm This patch removes only instance in this file. Problem is that there are many template files involved. Most of them have other instances of scrolling_lists but is a problem for other bugs, they will depend on this. What is replaced is a pulldown for delimiter choices. In all but one case the code is the same (variable name change), and I did a little tidy of the TT code To test: 1. Apply the patch In all the following cases, check delimiters pulldown (Output box, bottom right) 2. Go to Reports > Statistics wizard > Acquisitions 3. Go to Reports > Statistics wizard > Patrons 4. Go to Reports > Statistics wizard > Catalog 5. Go to Reports > Statistics wizard > Circulation 6. Go to Reports > Statistics wizard > Serials 7. Go to Reports > Statistics wizard > Holds there is a bug here, pulldown next to this must show 'CSV' option, but shows nothing. Will be fixed 8. Go to Reports > Other > Average loan time 9. Go to Reports > Top lists > Patron checking out the most Here there is a 'Delimiter' label before delimiters, only case 10. Go to Reports > Top lists > Most-circulated items 11. Go to Reports > Inactive > Patrons who haven't checked out There is and inconsistency here, name of option on reports page, and name on this report, 'Patrons with no checkouts' Followed test plan. Pulldowns display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 30851 [details] [review] [PASSED QA] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm This patch removes only instance in this file. Problem is that there are many template files involved. Most of them have other instances of scrolling_lists but is a problem for other bugs, they will depend on this. What is replaced is a pulldown for delimiter choices. In all but one case the code is the same (variable name change), and I did a little tidy of the TT code To test: 1. Apply the patch In all the following cases, check delimiters pulldown (Output box, bottom right) 2. Go to Reports > Statistics wizard > Acquisitions 3. Go to Reports > Statistics wizard > Patrons 4. Go to Reports > Statistics wizard > Catalog 5. Go to Reports > Statistics wizard > Circulation 6. Go to Reports > Statistics wizard > Serials 7. Go to Reports > Statistics wizard > Holds there is a bug here, pulldown next to this must show 'CSV' option, but shows nothing. Will be fixed 8. Go to Reports > Other > Average loan time 9. Go to Reports > Top lists > Patron checking out the most Here there is a 'Delimiter' label before delimiters, only case 10. Go to Reports > Top lists > Most-circulated items 11. Go to Reports > Inactive > Patrons who haven't checked out There is and inconsistency here, name of option on reports page, and name on this report, 'Patrons with no checkouts' Followed test plan. Pulldowns display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Patch pushed to master. Thanks Bernardo! |