Bug 12696 - Remove CGI::scrolling_list from C4/Reports.pm
Summary: Remove CGI::scrolling_list from C4/Reports.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 766 12706 12707
  Show dependency treegraph
 
Reported: 2014-08-02 02:06 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm (20.26 KB, patch)
2014-08-02 03:37 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[Signed-off] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm (20.46 KB, patch)
2014-08-05 07:55 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm (20.55 KB, patch)
2014-08-15 16:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-08-02 02:06:19 UTC
One in this file
Comment 1 Bernardo Gonzalez Kriegel 2014-08-02 03:37:30 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-05 07:55:12 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-15 16:54:33 UTC
Created attachment 30851 [details] [review]
[PASSED QA] Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm

This patch removes only instance in this file.
Problem is that there are many template files
involved. Most of them have other instances of
scrolling_lists but is a problem for other bugs,
they will depend on this.

What is replaced is a pulldown for delimiter choices.
In all but one case the code is the same (variable name change),
and I did a little tidy of the TT code

To test:
1. Apply the patch

In all the following cases, check delimiters pulldown (Output box, bottom right)

2. Go to Reports > Statistics wizard > Acquisitions
3. Go to Reports > Statistics wizard > Patrons
4. Go to Reports > Statistics wizard > Catalog
5. Go to Reports > Statistics wizard > Circulation
6. Go to Reports > Statistics wizard > Serials
7. Go to Reports > Statistics wizard > Holds
there is a bug here, pulldown next to this must show 'CSV' option,
but shows nothing. Will be fixed

8. Go to Reports > Other > Average loan time

9. Go to Reports > Top lists > Patron checking out the most
Here there is a 'Delimiter' label before delimiters, only case
10. Go to Reports > Top lists > Most-circulated items

11. Go to Reports > Inactive > Patrons who haven't checked out
There is and inconsistency here, name of option on reports page,
and name on this report, 'Patrons with no checkouts'

Followed test plan. Pulldowns display as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-08-15 18:02:20 UTC
Patch pushed to master.

Thanks Bernardo!