Bug 12701

Summary: OPAC reading history still accessible by URL if turned OFF
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: mirko, tomascohen, veron
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 12701 - OPAC reading history still accessible by URL if turned OFF
Bug 12701 - OPAC reading history still accessible by URL if turned OFF
[PASSED QA] Bug 12701 - OPAC reading history still accessible by URL if turned OFF

Description Katrin Fischer 2014-08-02 21:53:28 UTC
To reproduce:

- Make sure opacreadinghistory is activated.
- Verify you can access the page in your patron account in the OPAC.
- Copy URL.
- Turn off opacreadinghistory.
- Try to access the page again, the entry from the tabs is gone.
- Use again using the URL.
- Verify the page is still accessible :(
Comment 1 Owen Leonard 2014-11-18 15:52:47 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2014-11-19 17:54:22 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-11-19 20:52:26 UTC
Created attachment 33702 [details] [review]
[PASSED QA] Bug 12701 - OPAC reading history still accessible by URL if turned OFF

If the opacreadinghistory system preference is turned off it is still
possible to navigate directly to the OPAC reading history page if you
know the URL. This patch adapts the fix for Bug 10595 (OpacTopissue page
still accessible when system preference is turned off) for
opac-readingrecord.pl

To test, log in to the OPAC and test the following conditions:

- With opacreadinghistory, navigating directly to
  /cgi-bin/koha/opac-readingrecord.pl should trigger a 404 error.

- With opacreadinghistory turned on there should be a working link to
  "your reading history" in the left-hand sidebar menu.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described and passes tests.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-11-20 00:49:00 UTC
Patch pushed to master.

Thanks Owen!