Summary: | Only suggestion manager can order from accepted suggestion | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | edward.m.veal, jonathan.druart, nengard, paola.rossi, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17899 | ||
Attachments: |
Bug 12775: Suggestions should be ordered by anyone
Bug 12775: Suggestions should be ordered by anyone [PASSED QA] Bug 12775: Suggestions should be ordered by anyone |
Description
Kyle M Hall (khall)
2014-08-15 16:01:55 UTC
*** Bug 12846 has been marked as a duplicate of this bug. *** What's the expected behavior? I think in order to not annoy people... maybe a 2 step thing? like having the option to filter on your own easily? (and so avoiding to have to make this a pref?) I agree that it has been irritating to people I showed Koha to - because it can be 2 different people approving and ordering in bigger libraries. Created attachment 31693 [details] [review] Bug 12775: Suggestions should be ordered by anyone Currently only the suggestion manager can order from accepted suggestion. This patch set to default the ability to show all suggestions when ordering from a suggestion. 2 links "show only mine" and "show all" permits to filter/show all permissions. Test plan: Create an order from a suggestion and verify you are able to see all suggestions by default. Verify the "show only mine" link works as expected. Not sure this is a major. It seems that the behavior exists for 5 years now. Nicole and Kyle, could you tell me if this patch respond to your need? Created attachment 31891 [details] [review] Bug 12775: Suggestions should be ordered by anyone I've applied the patch against 3.17.00.025 Signed Off Created attachment 31992 [details] [review] [PASSED QA] Bug 12775: Suggestions should be ordered by anyone Currently only the suggestion manager can order from accepted suggestion. This patch set to default the ability to show all suggestions when ordering from a suggestion. 2 links "show only mine" and "show all" permits to filter/show all permissions. Test plan: Create an order from a suggestion and verify you are able to see all suggestions by default. Verify the "show only mine" link works as expected. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Jonathan! |