Summary: | Regression: Item lost status doesn't show in list of checkouts | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, mtj, nengard, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11703 | ||
Bug Blocks: | |||
Attachments: |
Bug 12778 - Regression: Item lost status doesn't show in list of checkouts
Bug 12778 - Regression: Item lost status doesn't show in list of checkouts [SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts [PASSED QA] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts |
Description
Katrin Fischer
2014-08-17 18:54:47 UTC
*** Bug 10623 has been marked as a duplicate of this bug. *** Created attachment 33526 [details] [review] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays Only the lost status should display. "Available" should not display for items which are not lost. Checking out 3.14.x and looking at the way it used to look is helpful. I notice that in 3.14.x the damaged status of items also appeared in that column the same way the lost status did. (In reply to Owen Leonard from comment #4) > Only the lost status should display. "Available" should not display for > items which are not lost. > > Checking out 3.14.x and looking at the way it used to look is helpful. I > notice that in 3.14.x the damaged status of items also appeared in that > column the same way the lost status did. I didn't take into account the possibility that the description for lost value 0 would be filled in ( it's not in the default data ). I will correct that and see if I can't do the same for the damaged status. Created attachment 33566 [details] [review] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays 5) Repeat this test plan for a damaged item Created attachment 33567 [details] [review] [SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays 5) Repeat this test plan for a damaged item Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with damaged and multiple lost values. Created attachment 33587 [details] [review] [PASSED QA] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays 5) Repeat this test plan for a damaged item Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with damaged and multiple lost values. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Patch pushed to master. Thanks Kyle! Pushed to 3.16.x, will be in 3.16.7 |