Bug 12839

Summary: aqbooksellers.gstreg is never used
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, francois.charbonnier, paola.rossi, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34207
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12826    
Attachments: Bug 12839: aqbooksellers.gstreg is never used
Bug 12839: aqbooksellers.gstreg is never used
[PASSED QA] Bug 12839: aqbooksellers.gstreg is never used

Description Jonathan Druart 2014-08-28 09:45:43 UTC

    
Comment 1 Jonathan Druart 2014-08-28 09:46:31 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2014-09-09 16:15:41 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-09-19 12:44:06 UTC
Created attachment 31740 [details] [review]
[PASSED QA] Bug 12839: aqbooksellers.gstreg is never used

The aqbooksellers.gstreg is never used in the code.
This patch does not remove the DB field but 3 useless occurrences in the
neworderempty page.

The both variable applygst and gstreg have never been took into account for prices calculation.

Test plan:
Verify there is no difference before and after the patch in the prices
calculation.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-12-03 14:52:55 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 5 Chris Cormack 2014-12-03 19:56:56 UTC
Pushed to 3.18.x will be in 3.18.01