Bug 12841

Summary: aqorders fields should not be mapped
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: chris, francois.charbonnier, tomascohen, ztajoli
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 12826    
Attachments: Bug 12841: aqorders fields should not be mapped
sign-off for patch
[SIGN_OFF] Aqorders fields should not be mapped
[PASSED QA] Bug 12841: aqorders fields should not be mapped

Description Jonathan Druart 2014-08-28 10:50:24 UTC
Bug 5336 introduced some code which should have been introduced by bug 7294.
Since the idea behind bug 7294 has been abandoned (map the aqorders fields), the code can be removed.
Comment 1 Jonathan Druart 2014-08-28 10:52:58 UTC Comment hidden (obsolete)
Comment 2 Zeno Tajoli 2014-09-13 10:13:08 UTC Comment hidden (obsolete)
Comment 3 Zeno Tajoli 2014-09-13 13:00:10 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall (khall) 2014-09-19 12:36:01 UTC
Created attachment 31737 [details] [review]
[PASSED QA] Bug 12841: aqorders fields should not be mapped

Bug 5336 introduced some code which should have been introduced by bug
7294.
Since the idea behind bug 7294 has been abandoned (map the aqorders
fields), the code can be removed.

Test plan:
Verify that Koha does not allow you to map the aqorders fields with a
MARC subfield.
Verify there is no regression on adding/updating an order.

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2014-12-03 14:53:40 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 6 Chris Cormack 2014-12-03 19:59:21 UTC
Pushed to 3.18.x will be in 3.18.01