Description
Chris Cormack
2014-09-15 02:47:09 UTC
Created attachment 31589 [details] [review] Bug 12919 : Module to facilitate sending new (or updated or deleted) cataloguing records somewhere Created attachment 31590 [details] [review] Bug 12919 : Cronjob to create and email new or updated MARC records To test 1/ Add some new records to your Koha 2/ if you are using koha from packages run sudo koha-shell <kohainstancename> otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your@email.goes.here --format marc 4/ Check your email and see if you got some marc records Created attachment 31591 [details] [review] Bug 12919 : Script to grab and email deleted records To test 1/ Delete some records from your Koha (with isbns) OR mark all items attached to a biblio as lost 2/ if you are using koha from packages run sudo koha-shell <kohainstancename> otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your@email.goes.here --lost --format isbn 4/ Check your email and see if you got a list of isbn of deleted records This is such a handy tool, it could really use a signoff. It works. Just a couple of things: 1) If you have no new or deleted records, an email is sent anyway with an empty Koha.mrc file 2) License needs to be updated FAIL misc/cronjobs/newly_deleted_records.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid FAIL misc/cronjobs/newly_added_records.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid Created attachment 39260 [details] [review] [SIGNED-OFF] Bug 12919 : Module to facilitate sending new (or updated or deleted) cataloguing records somewhere Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 39261 [details] [review] [SIGNED-OFF] Bug 12919: Cronjob to create and email new or updated MARC records To test 1/ Add some new records to your Koha 2/ if you are using koha from packages run sudo koha-shell <kohainstancename> otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your@email.goes.here --format marc 4/ Check your email and see if you got some marc records Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 39262 [details] [review] [SIGNED-OFF] Bug 12919: Script to grab and email deleted records To test 1/ Delete some records from your Koha (with isbns) OR mark all items attached to a biblio as lost 2/ if you are using koha from packages run sudo koha-shell <kohainstancename> otherwise export PERL5LIB=/path/to/koha export KOHA_CONF=/path/to/koha-conf.xml 3/ run perl misc/cronjobs/newly_added_records --days 1 --address your@email.goes.here --lost --format isbn 4/ Check your email and see if you got a list of isbn of deleted records Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, both patches A simple error on license, fixed in followup Created attachment 39263 [details] [review] Bug 12929: (followup) fix license I fix it myself. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Feature uses MIME::Lite but does not appear to add it to the dependencies list, can you please add that? Mime::Lite is already available as a package for Debian so I don't think it will be an issue for Koha packages. Hi Kyle, I see this in Master in C4/Installer/PerlDependencies.pm: 37 'MIME::Lite' => { 38 'usage' => 'Core', 39 'required' => '1', 40 'min_ver' => '3' 41 }, Is this not what is necessary? What more is needed? Cheers, Liz QA comments: 1/ perltidy new files 2/ Use pod2usage in pl scripts 3/ Write tests for new subroutines 4/ Be consistent with subroutine names (export_newrecords => export_new_records) Marked as Failed QA. Created attachment 40505 [details] [review] Bug 12919 - perltidy and consistent sub naming (In reply to Liz Rea from comment #13) > Created attachment 40505 [details] [review] [review] > Bug 12919 - perltidy and consistent sub naming Liz, could you confirm this one can leave the FQA queue? Nope, it still needs unit tests and pod2usage updates as well. Liz Comment on attachment 39260 [details] [review] [SIGNED-OFF] Bug 12919 : Module to facilitate sending new (or updated or deleted) cataloguing records somewhere Review of attachment 39260 [details] [review]: ----------------------------------------------------------------- Don't you think it would be better to sent the mail to the message queue and let the users define a template letter? ::: C4/RecordExporter.pm @@ +274,5 @@ > +sub get_isbns { > + my ($record) = @_; > + > + my $res = ''; > + my @fields = $record->field('020'); This is MARC21 specific. You should use a subroutine from C4::Koha. Making it use a letter template and the letter queue is a good idea, but a scope creep. Happy to make another bug for that once the dev itself goes in. Cheers, Liz Is anyone still working on this? Is it really 'assigned'? ASSIGNED status does indeed appear dubious, but don't feel qualified to update. (In reply to Cab Vinton from comment #19) > ASSIGNED status does indeed appear dubious, but don't feel qualified to > update. Adjusted to NEW. |