Bug 12716 removes too many lines. See bug 12859 for the history.
Created attachment 31637 [details] [review] Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list.
Created attachment 31969 [details] [review] [SIGNED-OFF] Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Confirmed that this patch removes borrowernumber from list of default values, and reintroduces missing list of CSV columns in the Notes field.
Kyle, the patch applies correctly here. Switch the status back to SO.
Created attachment 32129 [details] [review] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file
Created attachment 32143 [details] [review] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 32279 [details] [review] [PASSED QA] Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Confirmed that this patch removes borrowernumber from list of default values, and reintroduces missing list of CSV columns in the Notes field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32280 [details] [review] [PASSED QA] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, hides the borrowernumber from the list of fields to edit and also brings back the list of fields for the sample file in the documentation. Passes tests and QA script.
Patches pushed to master. Thanks Jonathan and Kyle.
Created attachment 32335 [details] [review] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, hides the borrowernumber from the list of fields to edit and also brings back the list of fields for the sample file in the documentation. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>