Summary: | Problems with item information tab on acq order from staged page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, paola.rossi, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13008 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12673 | ||
Bug Blocks: | |||
Attachments: |
Bug 12927: Problems with item information tab on acq order from staged page
Bug 12927: Problems with item information tab on acq order from staged page Bug 12927: Problems with item information tab on acq order from staged page |
Description
Katrin Fischer
2014-09-16 09:20:24 UTC
I'l fix this ASAP Created attachment 31639 [details] [review] Bug 12927: Problems with item information tab on acq order from staged page This patch fixes a regression introduced (by me) on Bug 12673. I adds the code needed to display properly all fields To test: 1) Check that 'AcqCreateItem' syspref is set to 'placing an order' 2) Satage a file with some items 3) Go to a Vendor, create a basket, clic add from staged file, select your file 4) On 'Item information' tab fields are displayed wrong 5) Apply the patch 6) Reload, display must now be fixed Created attachment 31915 [details] [review] Bug 12927: Problems with item information tab on acq order from staged page I've applied the patch against master 3.17.00.025 The display of the 11 dropdown lists in the "Item information" tag: 0 - Withdrawn status 2 - Source of classification or shelving scheme 4 - Damaged status 5 - Use restrictions 7 - Not for loan 8 - Collection code a - Permanent location b - Current location c - Shelving location j - Shelving control number y - Koha item type was fixed by the patch, as required. Before applying the patch, the error occurred either adding from a staged file with items (as by the test plan) or adding from a staged file without items. The error about displying dropdown lists is fixed in both these two cases. So I pass the patch to "Signed Off" status. ---------------------------------------------------------------------- NB. Either in master or after having applied the patch, ordering from a staged record with items adds no item. This is different from importing in the catalog: a staged record with items is imported in the catalog with all its items. On Tools, the"Stage MARC records for import" works well: after uploading a local file with items (with 952 and some subfields among 952$i, 952$o, 952$p, 952$r, 952$t, 952$w, 952$y, 952$z etc) the "MARC staging results" says (and it's true): [...] 1 item records found and staged [...] On ACQ, ordering from the staged file with items: A) in "Select to import" tag, the "MARC" view of the staged record shows no 952 field (ERROR?); B) in "Item information" tag, all the item's fields i (i.e.: i - Inventory number, o - Full call number, p - Barcode, t - Copy number, y - Koha item type, etc ) are shown empty (ERROR?); C) in "Select on import" tag, if I select "Add order" [and I "Create new record"], only the "Catalog details" fields are filled, whilst the "Item" fields are all empty (ERROR?). --------------------------------------------------------------------- Created attachment 31925 [details] [review] Bug 12927: Problems with item information tab on acq order from staged page This patch fixes a regression introduced (by me) on Bug 12673. I adds the code needed to display properly all fields To test: 1) Check that 'AcqCreateItem' syspref is set to 'placing an order' 2) Satage a file with some items 3) Go to a Vendor, create a basket, clic add from staged file, select your file 4) On 'Item information' tab fields are displayed wrong 5) Apply the patch 6) Reload, display must now be fixed Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch fixes the described issue but the one raised on comment 12673 comment 11 is still valid. (In reply to Jonathan Druart from comment #5) > This patch fixes the described issue but the one raised on comment 12673 > comment 11 is still valid. Forget that, it fixes exactly this issue. I mistook with another one. Patch pushed to master. Thanks Bernardo! |