Bug 12673 - Remove CGI::scrolling_list from C4::Items.pm
Summary: Remove CGI::scrolling_list from C4::Items.pm
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 12927 13008
  Show dependency treegraph
 
Reported: 2014-07-29 17:59 UTC by Bernardo Gonzalez Kriegel
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12673: Remove CGI::scrolling_list from C4::Items.pm (3.32 KB, patch)
2014-07-29 18:13 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12673: Remove CGI::scrolling_list from C4::Items.pm (3.34 KB, patch)
2014-07-31 14:17 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm (3.44 KB, patch)
2014-07-31 19:07 UTC, Owen Leonard
Details | Diff | Splinter Review
[ALREADY PUSHED] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm (3.58 KB, patch)
2014-08-02 20:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12673: Followup - fix display in serials-edit (2.17 KB, patch)
2014-08-13 16:49 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12673: Followup - fix display in serials-edit (2.27 KB, patch)
2014-08-13 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12673: Followup - fix display in serials-edit (2.31 KB, patch)
2014-08-13 23:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12673: (followup) fix Supplemental issue too (2.07 KB, patch)
2014-08-13 23:41 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2014-07-29 17:59:59 UTC
One instance in this file
Comment 1 Bernardo Gonzalez Kriegel 2014-07-29 18:13:17 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-07-31 14:17:16 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-07-31 19:07:25 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-08-02 20:55:03 UTC
Created attachment 30500 [details] [review]
[ALREADY PUSHED] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm

This patch removes only instance in this file

To test:
1. Apply the patch
2. (Esay way) Put on staff URL
/cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M
3. Code replaced corresponds to pulldowns, verify information
is correct (check with another item edit view)

PrepareItemrecordDisplay() in Items.pm is filled with chunks of
HTML code that must be put on TT file. For now scrolling_list
is the only removed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested different item edit displays and the URL given above,
no regressions found. Also passes all tests and QA script.
Comment 5 Tomás Cohen Arazi 2014-08-03 20:40:47 UTC
Patch pushed to master.

Thanks Bernardo!
Comment 6 Bernardo Gonzalez Kriegel 2014-08-13 16:49:38 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2014-08-13 17:52:29 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2014-08-13 23:40:57 UTC
Created attachment 30776 [details] [review]
[SIGNED OFF] Bug 12673: Followup - fix display in serials-edit

This patch fix the display of items information
following changes on previous patch.

To test:
1. Go to serials
2. Add a subscription
3. Receive an issue
4. Change status to Arrived
Item information display correct labels,
but no pulldowns, that's the bug
5. Apply the patch
6. Reload page, change to Arrived again,
this time pulldowns must be right

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as expected.
Comment 9 Tomás Cohen Arazi 2014-08-13 23:41:16 UTC
Created attachment 30777 [details] [review]
Bug 12673: (followup) fix Supplemental issue too

The same fix needs to be used for the 'Supplemental issue' part.
To test, use the same test steps used for the previous followup,
but choose "Arrived" in the 'Supplemental issue' row.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Comment 10 Tomás Cohen Arazi 2014-08-14 23:20:03 UTC
Followups pushed to master.

Thanks again, Bernardo!
Comment 11 Jonathan Druart 2014-08-28 14:49:54 UTC
This patch introduce a regression, I used git bisect, it pointed me:

4e278782f156a9d7452e6e9ddcefee9542b964fc is the first bad commit
commit 4e278782f156a9d7452e6e9ddcefee9542b964fc
Author: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Date:   Tue Jul 29 15:00:56 2014 -0300

    Bug 12673: Remove CGI::scrolling_list from C4::Items.pm
    
    This patch removes only instance in this file


To reproduce, go on acqui/addorderiso2709.pl?import_batch_id=3&basketno=7&booksellerid=5 (change ids), tab 'Item information'.
You will get:

b - Propriétaire HASH(0xd220cb0) Required
c - Dépositaire HASH(0xd44a3ec) Required
e - Localisation HASH(0xd44ab30) Required 

The dropdown list are replaced by the hashref address.